adoroszlai commented on code in PR #9704:
URL: https://github.com/apache/ozone/pull/9704#discussion_r2792006221
##########
pom.xml:
##########
@@ -2371,6 +2371,54 @@
</extensions>
</build>
+ <reporting>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <version>${maven-javadoc-plugin.version}</version>
+ <inherited>false</inherited>
+ <reportSets>
+ <reportSet>
+ <id>aggregate</id>
+ <reports>
+ <report>aggregate</report>
+ </reports>
+ <configuration>
+ <!-- Increase memory available to the javadoc JVM -->
+ <maxmemory>1024m</maxmemory>
+
+ <!-- Titles shown in the generated Javadoc -->
+ <doctitle>Apache Ozone API - ${project.version}</doctitle>
+ <windowtitle>Apache Ozone ${project.version} API</windowtitle>
+
+ <!-- Logical grouping and custom titles for packages -->
+ <groups>
+ <group>
+ <title>Core</title>
+ <packages>org.apache.ozone*</packages>
+ </group>
+ <group>
+ <title>Hadoop Ozone Integration</title>
+ <packages>org.apache.hadoop.ozone*</packages>
Review Comment:
`hadoop` appears in `org.apache.hadoop.ozone` for historical reason (Ozone
started as sub-project of Hadoop), it's not related to integration with Hadoop.
I don't think we need this grouping.
##########
pom.xml:
##########
@@ -2371,6 +2371,54 @@
</extensions>
</build>
+ <reporting>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-javadoc-plugin</artifactId>
+ <version>${maven-javadoc-plugin.version}</version>
+ <inherited>false</inherited>
+ <reportSets>
+ <reportSet>
+ <id>aggregate</id>
+ <reports>
+ <report>aggregate</report>
+ </reports>
+ <configuration>
+ <!-- Increase memory available to the javadoc JVM -->
+ <maxmemory>1024m</maxmemory>
+
+ <!-- Titles shown in the generated Javadoc -->
+ <doctitle>Apache Ozone API - ${project.version}</doctitle>
+ <windowtitle>Apache Ozone ${project.version} API</windowtitle>
+
+ <!-- Logical grouping and custom titles for packages -->
+ <groups>
+ <group>
+ <title>Core</title>
+ <packages>org.apache.ozone*</packages>
+ </group>
+ <group>
+ <title>Hadoop Ozone Integration</title>
+ <packages>org.apache.hadoop.ozone*</packages>
+ </group>
+ </groups>
+
+ <!-- Output settings and encoding -->
+
<reportOutputDirectory>${project.build.directory}/site</reportOutputDirectory>
+ <destDir>ozone-main/api</destDir>
Review Comment:
`hadoop-project/api` makes sense for Hadoop, because `hadoop-project` dir
exists and contains a module. `ozone-main` module is not in the `ozone-main`
dir, but in the root dir.
Isn't the default output directory fine?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
