len548 opened a new pull request, #9750: URL: https://github.com/apache/ozone/pull/9750
## What changes were proposed in this pull request? As a sub-task of [HDDS-12355](https://issues.apache.org/jira/browse/HDDS-12355), I converted `OzoneFileSystemTests` to abstract class (previously it was static final) and renamed it to `OzoneFileSystemTestBase`. This enables template method pattern and abstracts similar tests between `AbstractOzoneFileSystemTest` and `AbstractRootedOzoneFileSystemTest` easier. This PR also addresses: * Remove `testOzoneFsServiceLoader` from both test classes because `FileSystem.getFileSystemClass()` is Hadoop's code, not Ozone's. We should test our implementation, not the framework's behavior * Abstract `testCreateKeyWithECReplicationConfig` and `testListStatusIteratorWithDir` to `OzoneFileSystemTestBase` class. * Move `setPageSize` method to a new class `OzoneFileSystemTestUtils` from old `OzoneFileSystemTests`. Since there are a lot of duplicates in the two test classes, subsequent Jira tickets will continue to evaluate other duplicate tests if this approach is accepted. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-14608 ## How was this patch tested? Existing test suites are not broken by this PR. CI pass: https://github.com/len548/ozone/actions/runs/21897543317 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
