ivanzlenko commented on code in PR #9771:
URL: https://github.com/apache/ozone/pull/9771#discussion_r2811057743
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/metrics/S3GatewayMetrics.java:
##########
@@ -304,12 +304,17 @@ public void close() {
* @return S3GatewayMetrics
*/
public static synchronized S3GatewayMetrics create(OzoneConfiguration conf) {
+ if (!conf.getBoolean(S3GatewayConfigKeys.OZONE_S3G_METRICS_ENABLED,
+ S3GatewayConfigKeys.OZONE_S3G_METRICS_ENABLED_DEFAULT)) {
+ return null;
+ }
if (instance != null) {
return instance;
}
MetricsSystem ms = DefaultMetricsSystem.instance();
instance = ms.register(SOURCE_NAME, "S3 Gateway Metrics",
new S3GatewayMetrics(conf));
+ Runtime.getRuntime().addShutdownHook(new
Thread(S3GatewayMetrics::unRegister));
Review Comment:
What is the point of this Shutdown hook anyway? We will unregister metrics
on server stop anyway.
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java:
##########
@@ -117,6 +117,14 @@ public void setup() throws Exception {
metrics = bucketEndpoint.getMetrics();
}
+ @Test
+ public void testMetricsCreateIsIdempotent() {
Review Comment:
Would've be lovely to have tests which verify the configuration as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
