sarvekshayr commented on code in PR #9769:
URL: https://github.com/apache/ozone/pull/9769#discussion_r2813323730
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/common/volume/TestVolumeSet.java:
##########
@@ -155,33 +145,24 @@ public void testVolumeInInconsistentState() throws
Exception {
assertNumVolumes(volumeSet, 2, 0);
assertEquals(2, volumeSet.getVolumesList().size());
- // Add a volume to VolumeSet
- String volume3 = baseDir + "disk3";
+ String volume3 = baseDir.resolve("disk3").toString();
- // Create the root volume dir and create a sub-directory within it.
File newVolume = new File(volume3, HDDS_VOLUME_DIR);
- System.out.println("new volume root: " + newVolume);
assertTrue(newVolume.mkdirs());
- assertTrue(newVolume.exists(), "Failed to create new volume root");
File dataDir = new File(newVolume, "chunks");
assertTrue(dataDir.mkdirs());
assertTrue(dataDir.exists());
Review Comment:
Let's remove the redundant check here as well.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
