adoroszlai commented on code in PR #6916:
URL: https://github.com/apache/ozone/pull/6916#discussion_r2827104706
##########
.github/workflows/ci.yml:
##########
@@ -166,6 +166,129 @@ jobs:
path: |
~/.m2/repository/org/apache/ozone
retention-days: 1
+ build-config-doc:
+ needs:
+ - build
+ if: ${{ github.repository == 'apache/ozone' && github.event_name == 'push'
&& github.ref_name == 'master' }}
+ runs-on: ubuntu-latest
+ steps:
Review Comment:
Can `update-ozone-site-config-doc` be extracted, too? Changes in `ci.yml`
trigger full CI. I would like to avoid that for changes that only tweak this
job.
##########
dev-support/rat/rat-exclusions.txt:
##########
@@ -70,4 +70,4 @@ src/test/resources/prometheus-test-response.txt
**/dependency-reduced-pom.xml
# hadoop-ozone/tools
-src/test/resources/*.log
\ No newline at end of file
+src/test/resources/*.log
Review Comment:
nit: unrelated whitespace-only change.
##########
.github/workflows/ci.yml:
##########
@@ -124,6 +124,188 @@ jobs:
with-coverage: ${{ fromJSON(needs.build-info.outputs.with-coverage) }}
secrets: inherit
+ generate-config-doc:
+ needs:
+ - build-info
+ - build
+ # Allow running for any branch in forks for testing, but only master in
apache/ozone
+ if: |
+ needs.build-info.outputs.needs-build == 'true' &&
+ (github.repository != 'apache/ozone' || (github.event_name == 'push' &&
github.ref_name == 'master'))
Review Comment:
Shouldn't we run `generate-config-doc` (but not `update-...`) for pull
requests in `apache/ozone`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
