[
https://issues.apache.org/jira/browse/HDDS-13777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18059659#comment-18059659
]
Attila Doroszlai commented on HDDS-13777:
-----------------------------------------
BTW, labeling depending on target branch does not add much value, since PRs can
be filtered by branch:
https://github.com/apache/ozone/pulls?q=is%3Apr+is%3Aopen+base%3AHDDS-14496-zdu
> Remove label-pr workflow
> ------------------------
>
> Key: HDDS-13777
> URL: https://issues.apache.org/jira/browse/HDDS-13777
> Project: Apache Ozone
> Issue Type: Improvement
> Components: CI
> Reporter: Attila Doroszlai
> Assignee: Attila Doroszlai
> Priority: Major
>
> {{label-pr}} workflow was added back when container reconciler work was in
> early stages. Its purpose is to automatically add label
> {{container-reconciliation}} on pull requests targeted at feature branch
> {{HDDS-10239-container-reconciliation}}.
> The labeler workflow is executed on event {{pull_request_target}}, which is
> allowed for any user. Other workflows are triggered by {{pull_request}}, and
> need to be manually approved by a committer for PRs opened by non-committers.
> Such PRs may show "all checks passed" (green checkmark) even if only
> {{label-pr}} has been executed, other workflows are pending. This is
> confusing and we have seen some PRs being merged without regular CI checks
> due to this.
> I propose to change {{label-pr}} to trigger on {{pull_request}}, and thus
> require approval like other workflows.
> Alternatively, we may consider removing it completely.
> {{HDDS-10239-container-reconciliation}} has been merged into {{master}} and
> no other rules were added.
> CC [~erose]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
