[
https://issues.apache.org/jira/browse/HDDS-14682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Andika updated HDDS-14682:
-------------------------------
Description:
See the following TODO in
[https://github.com/apache/ozone/blob/a69f4d855587032544e4b2fd8e6681e7441243a8/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/Hadoop3OmTransport.java#L81-L84]
{code:java}
// TODO: It should be possible to simply instantiate
HadoopRpcOMFollowerReadFailoverProxyProvider
// even if the follower read is not enabled. We can try this to ensure that
the tests still pass which
// suggests that the HadoopRpcOMFollowerReadFailoverProxyProvider is a indeed
a superset of
// HadoopRpcOMFollowerReadFailoverProxyProvider {code}
Since HadoopRpcOMFollowerReadFailoverProxyProvider should be able to support
both OM follower and OM leader request flows, we can always use
HadoopRpcOMFollowerReadFailoverProxyProvider for the OzoneManagerProtocolPB
failover proxy provider. This will unify some of the implementations such as
the client read consistency implementation in HDDS-14509.
This means that HadoopRpcOMFailoverProxyProvider is only used for other OM
non-OzoneManagerProtocolPB protocols (e.g. OMAdminProtocolPB).
was:
See the following TODO in
[https://github.com/apache/ozone/blob/a69f4d855587032544e4b2fd8e6681e7441243a8/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/Hadoop3OmTransport.java#L81-L84]
{code:java}
// TODO: It should be possible to simply instantiate
HadoopRpcOMFollowerReadFailoverProxyProvider
// even if the follower read is not enabled. We can try this to ensure that
the tests still pass which
// suggests that the HadoopRpcOMFollowerReadFailoverProxyProvider is a indeed
a superset of
// HadoopRpcOMFollowerReadFailoverProxyProvider {code}
Since HadoopRpcOMFollowerReadFailoverProxyProvider should be able to support
both OM follower and OM leader request flows, we can always use
HadoopRpcOMFollowerReadFailoverProxyProvider for the OzoneManagerProtocolPB
failover proxy provider. This will unify some of the implementations such as
the client read consistency implementation in HDDS-14509.
> Unify OzoneManagerProtocolPB failover proxy provider
> ----------------------------------------------------
>
> Key: HDDS-14682
> URL: https://issues.apache.org/jira/browse/HDDS-14682
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Ivan Andika
> Assignee: Ivan Andika
> Priority: Major
>
> See the following TODO in
> [https://github.com/apache/ozone/blob/a69f4d855587032544e4b2fd8e6681e7441243a8/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/Hadoop3OmTransport.java#L81-L84]
> {code:java}
> // TODO: It should be possible to simply instantiate
> HadoopRpcOMFollowerReadFailoverProxyProvider
> // even if the follower read is not enabled. We can try this to ensure that
> the tests still pass which
> // suggests that the HadoopRpcOMFollowerReadFailoverProxyProvider is a
> indeed a superset of
> // HadoopRpcOMFollowerReadFailoverProxyProvider {code}
> Since HadoopRpcOMFollowerReadFailoverProxyProvider should be able to support
> both OM follower and OM leader request flows, we can always use
> HadoopRpcOMFollowerReadFailoverProxyProvider for the OzoneManagerProtocolPB
> failover proxy provider. This will unify some of the implementations such as
> the client read consistency implementation in HDDS-14509.
> This means that HadoopRpcOMFailoverProxyProvider is only used for other OM
> non-OzoneManagerProtocolPB protocols (e.g. OMAdminProtocolPB).
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
