adoroszlai commented on code in PR #9797:
URL: https://github.com/apache/ozone/pull/9797#discussion_r2833287869


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/ozone/AbstractOzoneFileSystemTest.java:
##########
@@ -156,7 +156,6 @@ abstract class AbstractOzoneFileSystemTest extends 
OzoneFileSystemTestBase {
   private MiniOzoneCluster cluster;
   private OzoneClient client;
   private OzoneManagerProtocol writeClient;
-  private FileSystem fs;
   private OzoneFileSystem o3fs;

Review Comment:
   Can we keep the name `fs` instead of `o3fs` and `ofs`, respectively?  Not 
only does it reduce change for this patch (due to way more usage of `fs` vs. 
`o3fs`/`ofs`), it keeps the test code in the two classes more similar, which 
helps further refactoring.
   
   ```java
     private OzoneFileSystem fs;
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to