adoroszlai opened a new pull request, #9808:
URL: https://github.com/apache/ozone/pull/9808

   ## What changes were proposed in this pull request?
   
   Currently the `pull-request-labeler` workflow is executed on 
`pull_request_target`, which is allowed for any user.  Other PR workflows are 
triggered by `pull_request`, and need to be manually approved by a committer 
for PRs opened by non-committers.  Such PRs may show "all checks passed" (green 
checkmark) even if only `label-pr` has been executed, other workflows are 
pending.  This is confusing and we have seen some PRs being merged without 
regular CI checks due to this.
   
   This PR changes the `pull-request-labeler` workflow (renamed to 
`label-pull-requests`) to run on `schedule` instead of `pull_request_target`.  
It can also be started manually (by committers) for easier testing.
   
   It replaces `actions/labeler` with GitHub CLI for adding labels.  The action 
expects input `pr-number` one item per line, which I couldn't achieve with 
either `GITHUB_OUTPUT` or `GITHUB_ENV`.
   
   https://issues.apache.org/jira/browse/HDDS-13777
   
   ## How was this patch tested?
   
   Tested in my fork with two pull requests (targeted at `master`, so 
temporarily added a matrix item for `master`):
   - https://github.com/adoroszlai/ozone/pull/32
   - https://github.com/adoroszlai/ozone/pull/33
   
   Only manual triggering was tested, scheduled runs were not triggered for 
some reason (does not seem to be a unique problem, see 
https://github.com/orgs/community/discussions/185828).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to