Gargi-jais11 commented on code in PR #9812:
URL: https://github.com/apache/ozone/pull/9812#discussion_r2846018681
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java:
##########
@@ -510,4 +513,22 @@ public String toString() {
"%-30s %b%n", "Key", "Value", "Running", isBalancerRunning());
return status + config.toString();
}
+
+ private void validateNodeList(java.util.Set<String> nodes, String type)
Review Comment:
import `java.util.Set`
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/balancer/TestContainerBalancerTask.java:
##########
@@ -411,6 +413,27 @@ public void balancerShouldMoveOnlyPositiveSizeContainers()
assertFalse(zeroOrNegSizeContainerMoved);
}
+ @Test
+ public void testStartBalancerWithInvalidNodes() {
Review Comment:
In this test itself check giving invalid hostnames or ip to excluded nodes
wether error is thrown or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
