sodonnel commented on code in PR #9836:
URL: https://github.com/apache/ozone/pull/9836#discussion_r2877968624
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/NodeStateManager.java:
##########
@@ -847,14 +764,6 @@ public synchronized void checkNodesHealth() {
updateNodeState(node, staleNodeCondition, status,
NodeLifeCycleEvent.TIMEOUT);
break;
- case HEALTHY_READONLY:
- updateNodeLayoutVersionState(node, layoutMatchCondition, status,
- NodeLifeCycleEvent.LAYOUT_MATCH);
Review Comment:
I missed this part. I think you are correct. All this is doing is deciding
whether to move the node to HEALTH if it was readonly, and the part I did not
remove moves to read_only if the layouts mis-match.
Now, we don't want to move the node state on any layout miss-match, so it
should be possible to just remove this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
