adoroszlai commented on code in PR #9859:
URL: https://github.com/apache/ozone/pull/9859#discussion_r2879247078
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/OzoneConfigKeys.java:
##########
@@ -469,6 +469,15 @@ public final class OzoneConfigKeys {
"ozone.acl.enabled";
public static final boolean OZONE_ACL_ENABLED_DEFAULT =
false;
+ public static final String OZONE_AUTHORIZATION_ENABLED =
"ozone.authorization.enabled";
+ public static final boolean OZONE_AUTHORIZATION_ENABLED_DEFAULT = true;
+ /**
+ * Test-only configuration property to enable authorization checks without
+ * requiring full security (Kerberos) setup. This is for testing purposes
+ * only and should not be used in production.
+ */
+ public static final String OZONE_TEST_AUTHORIZATION_ENABLED =
"ozone.test.authorization.enabled";
+ public static final boolean OZONE_TEST_AUTHORIZATION_ENABLED_DEFAULT = false;
Review Comment:
These constants should be moved to some other class, to avoid
[failure](https://github.com/Gargi-jais11/ozone/actions/runs/22623766185/job/65556383214#step:13:5848)
in `TestOzoneConfigurationFields`.
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/security/acl/TestOzoneAuthorizerFactory.java:
##########
@@ -173,7 +173,6 @@ private static OzoneManager omMock(OzoneConfiguration conf,
.thenReturn(conf);
when(om.getAclsEnabled())
.thenReturn(aclEnabled);
-
Review Comment:
nit: please avoid whitespace-only change in this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
