adoroszlai commented on code in PR #9867:
URL: https://github.com/apache/ozone/pull/9867#discussion_r2887835006
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1726,6 +1730,19 @@ message PartKeyInfo {
required KeyInfo partKeyInfo = 3;
}
+message MultipartPartInfo {
Review Comment:
If this only affects OM-side storage, it should be added in
`interface-storage` instead of `interface-client`.
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1726,6 +1730,19 @@ message PartKeyInfo {
required KeyInfo partKeyInfo = 3;
}
+message MultipartPartInfo {
+ required string partName = 1;
+ required uint32 partNumber = 2;
+ repeated KeyLocationList keyLocationList = 6;
+ required uint64 dataSize = 7;
+ required uint64 modificationTime = 8;
+ required uint64 objectID = 9;
+ required uint64 updateID = 10;
+ repeated hadoop.hdds.KeyValue metadata = 11;
Review Comment:
See https://github.com/apache/ozone/pull/9793#pullrequestreview-3868200967
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1726,6 +1730,19 @@ message PartKeyInfo {
required KeyInfo partKeyInfo = 3;
}
+message MultipartPartInfo {
+ required string partName = 1;
+ required uint32 partNumber = 2;
+ repeated KeyLocationList keyLocationList = 6;
+ required uint64 dataSize = 7;
+ required uint64 modificationTime = 8;
+ required uint64 objectID = 9;
+ required uint64 updateID = 10;
Review Comment:
Shouldn't we add these as `optional`?
https://protobuf.dev/programming-guides/style/#required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
