devabhishekpal commented on code in PR #9867:
URL: https://github.com/apache/ozone/pull/9867#discussion_r2895199396
##########
hadoop-ozone/interface-client/src/main/proto/OmClientProtocol.proto:
##########
@@ -1726,6 +1730,19 @@ message PartKeyInfo {
required KeyInfo partKeyInfo = 3;
}
+message MultipartPartInfo {
+ optional string partName = 1;
Review Comment:
So this was pointed out by Attila, one problem with keeping as `required`
fields is:
- This makes it harder to migrate or change fields later down the line, like
if say the field type needs to be changed, or partName needs to be split or
something like that - older clients will always expect part name which will
break that.
- proto3 no longer supports `required` fields and it is deprecated.
Instead the required fields will be enforced at the CODEC / application
level and throw error in case they are empty
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
