guihecheng commented on pull request #2290: URL: https://github.com/apache/ozone/pull/2290#issuecomment-853752890
> The approach looks good. I would prefer to have metadata and data volume in two different sets altogether as well. Do we need to consider the case where metadata and data volumes share the same underlying physical disk. I such cases, the disk checker might run more frequently. Its ok to not address the problem here but something to take note of. Sure, I've updated with the separated VolumeSets approach, also with separated 'tolerated' configs, checklist updated above. In order to check whether the underlying physical disks are the same, we need to access the fsid of the local fs, it should be nice to have but not very urgent. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
