sodonnel commented on code in PR #9829:
URL: https://github.com/apache/ozone/pull/9829#discussion_r2932426011
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/QuasiClosedStuckReplicaCount.java:
##########
@@ -106,28 +157,29 @@ public List<MisReplicatedOrigin>
getUnderReplicatedReplicas() {
misReplicatedOrigins.add(new MisReplicatedOrigin(entry.getValue(),
additionalReplicas));
}
} else {
- if (inService.size() < 3) {
- int additionalReplicas = 3 - inService.size();
+ if (inService.size() < bestOriginCopies) {
Review Comment:
Is this change correct? This is the case for only 1 origin available, so we
always want to have 3 copies, even if the configuration is set to 2. I'm not
sure we need to change the logic in this part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
