chungen0126 commented on PR #9932: URL: https://github.com/apache/ozone/pull/9932#issuecomment-4068178845
Thanks @ivandika3 for working on this. However, I’m not entirely convinced that this is the right approach: - Performance Impact: I’m concerned we are sacrificing consistency for a minimal benefit. Is there any production data showing that this change actually optimizes the system?" - Consistency Trade-off: Moving createFakeDirIfShould out the lock might compromise the atomicity of the operation. If we proceed with this, we should at least consider making it a configurable option so users can choose between performance and strict consistency. In my opinion, the risk of breaking consistency might outweigh the benefits here. Would love to hear your thoughts on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
