sumitagrawl commented on code in PR #9914:
URL: https://github.com/apache/ozone/pull/9914#discussion_r2944870305
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java:
##########
@@ -124,6 +131,8 @@ protected PipelineManagerImpl(ConfigurationSource conf,
HddsConfigKeys.HDDS_PIPELINE_REPORT_INTERVAL_DEFAULT,
TimeUnit.MILLISECONDS);
this.freezePipelineCreation = new AtomicBoolean();
+ this.pipelineExcludedNodes =
conf.getObject(ScmConfig.class).getPipelineExcludedNodes();
+ this.configuredExcludedDatanodeDetails =
resolvePipelineExcludedNodesToDatanodeDetails();
Review Comment:
To simplify, this needs to be part of NodeManager as holder, and to be
retrieved on need basis, so that dyanmically update of new dn added / removed
can be handled.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineManagerImpl.java:
##########
@@ -124,6 +131,8 @@ protected PipelineManagerImpl(ConfigurationSource conf,
HddsConfigKeys.HDDS_PIPELINE_REPORT_INTERVAL_DEFAULT,
TimeUnit.MILLISECONDS);
this.freezePipelineCreation = new AtomicBoolean();
+ this.pipelineExcludedNodes =
conf.getObject(ScmConfig.class).getPipelineExcludedNodes();
+ this.configuredExcludedDatanodeDetails =
resolvePipelineExcludedNodesToDatanodeDetails();
Review Comment:
When any new dn is added, configuredExcludedDatanodeDetails can change to
include that dn earlier not reported. So this needs dynamically refreshed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
