errose28 commented on code in PR #9715:
URL: https://github.com/apache/ozone/pull/9715#discussion_r2962590868
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/upgrade/FinalizationStateManagerImpl.java:
##########
@@ -99,8 +99,11 @@ public void addFinalizingMark() throws IOException {
}
@Override
- public void finalizeLayoutFeature(Integer layoutVersion) throws IOException {
- finalizeLayoutFeatureLocal(layoutVersion);
+ public void finalizeLayoutFeatures(Integer toVersion) throws IOException {
+ int startLayoutVersion = versionManager.getMetadataLayoutVersion() + 1;
Review Comment:
The `toVersion` parameter will be used checked against our software version
in a future change to make sure all machines are running the same software
version before proceeding with finalization. We can just use
`versionManager.unfinalizedFeatures` to actually iterate the features and send
them in for finalization though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
