ChenSammi commented on code in PR #9947:
URL: https://github.com/apache/ozone/pull/9947#discussion_r2964417493
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -326,17 +327,30 @@ public VolumeCheckResult checkDbHealth(File dbFile)
throws InterruptedException
return VolumeCheckResult.HEALTHY;
}
+ // We attempt to open RocksDb twice to ignore any transient errors
+ // and to confirm that we actually cannot open RocksDb in readonly mode.
final boolean isVolumeTestResultHealthy = true;
- try (ManagedOptions managedOptions = new ManagedOptions();
- ManagedRocksDB ignored = ManagedRocksDB.openReadOnly(managedOptions,
dbFile.toString())) {
- volumeTestResultQueue.add(isVolumeTestResultHealthy);
- } catch (Exception e) {
- if (Thread.currentThread().isInterrupted()) {
- throw new InterruptedException("Check of database for volume " + this
+ " interrupted.");
+ final int maxAttempts = 2;
+ final Duration maxRetryGap = getDatanodeConfig().getDiskCheckRetryGap();
+ for (int attempt = 0; attempt < maxAttempts; attempt++) {
+ try (ManagedOptions managedOptions = new ManagedOptions();
+ ManagedRocksDB ignored =
ManagedRocksDB.openReadOnly(managedOptions, dbFile.toString())) {
+ volumeTestResultQueue.add(isVolumeTestResultHealthy);
+ break;
+ } catch (Exception e) {
+ if (Thread.currentThread().isInterrupted()) {
+ throw new InterruptedException("Check of database for volume " +
this + " interrupted.");
+ }
+
+ if (attempt == maxAttempts - 1) {
Review Comment:
Basically here it does retry for any failure, not just transient errors.
Do we know which errora are transient that could be recovered by retry, and
which errors cannot?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
