fmorg-git commented on code in PR #9894: URL: https://github.com/apache/ozone/pull/9894#discussion_r2967759255
########## hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/protocol/ListStatusLightOptions.java: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.client.protocol; + +import java.util.Objects; + +/** + * Options for {@link ClientProtocol#listStatusLight(ListStatusLightOptions)}. + * Encapsulates all parameters to allow future extensibility without breaking + * the method signature. + */ +public final class ListStatusLightOptions { + + private final String volumeName; + private final String bucketName; + private final String keyName; + private final boolean recursive; + private final String startKey; + private final long numEntries; + private final boolean allowPartialPrefixes; + // When keyName is empty (root listing), this is the original S3/list + // prefix for STS auth. Enables LIST check on this prefix instead of "*". + private final String listPrefix; Review Comment: right, the existing logic is very complex, that's why I took the original approach of passing an additional `listPrefix` parameter that no one else is using and use that for my STS authentication, so I wouldn't have to change any existing logic. Furthermore, I am not certain if there is sufficient test coverage to ensure there are no regressions to the existing logic if I changed it for all the edge cases in listing. I tried your suggestion, and it passed all my STS smoke tests and didn't seem to change the baseline behavior, at least for the cases I have here: https://github.com/fmorg-git/ozone/blob/bb1359fb69bc4df23d5c294fcd2f4f62fc8ed0b9/hadoop-ozone/dist/src/main/smoketest/security/ozone-secure-sts.robot#L61-L190 so I'm fine with this change from STS perspective and updated the commit - my only concern would be any regressions but if you're confident, we can go with this approach. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
