adoroszlai commented on code in PR #9952:
URL: https://github.com/apache/ozone/pull/9952#discussion_r2971627523
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/io/ScmCodecFactory.java:
##########
@@ -74,35 +75,36 @@ public final class ScmCodecFactory {
putEnum(NodeType.class, NodeType::forNumber);
// Must be the last one
- final ClassResolver resolver = new ClassResolver(codecs.keySet());
+ resolver = new ClassResolver(codecs.keySet());
codecs.put(List.class, new ScmListCodec(resolver));
}
- static <T extends Message> void putProto(T proto) {
+ private <T extends Message> void putProto(T proto) {
final Class<? extends Message> clazz = proto.getClass();
codecs.put(clazz, new
ScmNonShadedGeneratedMessageCodec<>(clazz.getSimpleName(),
proto.getParserForType()));
}
- static <T extends Enum<T> & ProtocolMessageEnum> void putEnum(
+ private <T extends Enum<T> & ProtocolMessageEnum> void putEnum(
Class<T> enumClass, IntFunction<T> forNumber) {
codecs.put(enumClass, new ScmEnumCodec<>(enumClass, forNumber));
}
- private ScmCodecFactory() { }
+ public static ScmCodecFactory getInstance() {
+ return INSTANCE;
+ }
- public static ScmCodec getCodec(Class<?> type)
+ public Class<?> resolve(String className)
throws InvalidProtocolBufferException {
- final List<Class<?>> classes = new ArrayList<>();
- classes.add(type);
- classes.addAll(ClassUtils.getAllSuperclasses(type));
- classes.addAll(ClassUtils.getAllInterfaces(type));
Review Comment:
https://github.com/Russole/ozone/compare/HDDS-14846...adoroszlai:ozone:HDDS-14846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
