sreejasahithi commented on code in PR #9964:
URL: https://github.com/apache/ozone/pull/9964#discussion_r2972553601
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/balancer/TestContainerBalancerSelectionCriteria.java:
##########
@@ -135,4 +139,52 @@ public void shouldExcludeReplicatingContainer()
verify(replicationManager, times(1)).getContainerReplicationHealth(
eq(containerInfo), anySet());
}
+
+ @Test
+ public void shouldIncludeNonStandardContainers() throws Exception {
Review Comment:
This test only tests Case A (CLOSED, OVER_REPLICATED, 3 CLOSED + 1
QUASI_CLOSED). There is no test for Case B (QUASI_CLOSED container with all
QUASI_CLOSED replicas)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
