ChenSammi commented on code in PR #9954:
URL: https://github.com/apache/ozone/pull/9954#discussion_r2992558825
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/StorageVolumeChecker.java:
##########
@@ -376,10 +399,22 @@ public void onFailure(@Nonnull Throwable t) {
volume, exception);
// If the scan was interrupted, do not count it as a volume failure.
// This should only happen if the volume checker is being shut down.
- if (!(t instanceof InterruptedException)) {
- markFailed();
- cleanup();
+ if (t instanceof InterruptedException) {
+ return;
+ }
+ if (exception instanceof TimeoutException) {
Review Comment:
Devesh, can you add a unit test of real timeout case for both check all
volume and check one volume? The exception thrown out from ListenableFuture is
not direct TimeoutException in my test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
