arunsarin85 commented on code in PR #9928:
URL: https://github.com/apache/ozone/pull/9928#discussion_r3002494282
##########
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/v2/pages/buckets/buckets.tsx:
##########
@@ -262,16 +262,19 @@ const Buckets: React.FC<{}> = () => {
onChange={handleVolumeChange}
fixedColumn=''
onTagClose={() => { }}
- columnLength={volumeOptions.length} />
+ columnLength={volumeOptions.length}
+ showSearch={true}
+ showSelectAll={true} />
<MultiSelect
options={columnOptions}
defaultValue={selectedColumns}
selected={selectedColumns}
placeholder='Columns'
onChange={handleColumnChange}
onTagClose={() => { }}
- fixedColumn='name'
- columnLength={COLUMNS.length} />
+ fixedColumn={['name', 'volumeName']}
+ columnLength={COLUMNS.length}
+ showSelectAll={true} />
<SingleSelect
options={LIMIT_OPTIONS}
defaultValue={selectedLimit}
Review Comment:
Added menuPortalTarget={document.body} to the Select in singleSelect.tsx.
This portals the dropdown outside the component's DOM subtree - the same
approach MultiSelect already uses. The selectStyles in select.constants.tsx
already has menuPortal: zIndex: 9999 defined, so that rule now applies to
SingleSelect as well with no further changes needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
