adoroszlai commented on code in PR #9963:
URL: https://github.com/apache/ozone/pull/9963#discussion_r3005070141
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -127,6 +127,8 @@ private void addPropertiesNotInXml() {
OMConfigKeys.OZONE_THREAD_NUMBER_KEY_DELETION,
ScmConfigKeys.OZONE_SCM_PIPELINE_PLACEMENT_IMPL_KEY,
ScmConfigKeys.OZONE_SCM_HA_PREFIX,
+ ScmConfigKeys.OZONE_SCM_HA_RAFT_LOG_APPEND_ENTRIES_COMPOSE_ENABLED,
+ OMConfigKeys.OZONE_OM_RATIS_LOG_APPEND_ENTRIES_COMPOSE_ENABLED,
Review Comment:
Not adding to `ozone-default.xml` implies that the properties are
undocumented. But the corresponding datanode config is documented. I think we
should make all 3 documented or undocumented consistently.
If you wish to not document them, then the constants can be moved to the
place of usage (`RatisUtil` and `OzoneManagerRatisServer`) for simplicity, then
the exclusion is unnecessary. In that case the datanode-specific config should
also be moved to `XceiverServerRatis` from `DatanodeRatisServerConfig`.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/RatisUtil.java:
##########
@@ -196,6 +196,12 @@ private static int setRaftLogProperties(final
RaftProperties properties,
ozoneConf.getInt(ScmConfigKeys.OZONE_SCM_HA_RAFT_LOG_PURGE_GAP,
ScmConfigKeys.OZONE_SCM_HA_RAFT_LOG_PURGE_GAP_DEFAULT));
Log.setSegmentCacheNumMax(properties, 2);
+ properties.setBoolean(
+ "raft.server.log.append-entries.compose.enabled",
+ ozoneConf.getBoolean(
+ ScmConfigKeys.OZONE_SCM_HA_RAFT_LOG_APPEND_ENTRIES_COMPOSE_ENABLED,
+ ScmConfigKeys.
+ OZONE_SCM_HA_RAFT_LOG_APPEND_ENTRIES_COMPOSE_ENABLED_DEFAULT));
Review Comment:
Ideally we should use the type-safe API
(`Log.setAppendEntriesComposeEnabled`). I understand that this will be
available only in Ratis 3.2.2 and later, but the same applies to the behavioral
change triggered by this config. So I think we can wait with until then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
