jojochuang commented on a change in pull request #2296:
URL: https://github.com/apache/ozone/pull/2296#discussion_r646460588



##########
File path: 
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogStateManager.java
##########
@@ -27,7 +27,8 @@
 import java.util.ArrayList;
 
 /**
- * TODO: javadoc.
+ * DeletedBlockLogStateManager interface to provide BlocksTransaction

Review comment:
       I think we can make this more verbose.
   
   if you trace the code, you'll find it ultimately writes to 
SCMMetadataStore.getDeletedBlocksTXTable() which says "A Table that keeps the 
deleted blocks lists and transactions."
   
   You might say it's an interface to manage deleted blocks and record them in 
the underlying persist store.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to