szetszwo commented on code in PR #10013:
URL: https://github.com/apache/ozone/pull/10013#discussion_r3017517524


##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAInvocationHandler.java:
##########
@@ -104,12 +104,17 @@ private Object invokeRatis(Method method, Object[] args)
     if (LOG.isTraceEnabled()) {
       LOG.trace("Invoking method {} on target {}", method, ratisHandler);
     }
+
     try {
       switch (method.getAnnotation(Replicate.class).invocationType()) {
       case CLIENT:
         return invokeRatisClient(method, args);
       case DIRECT:
       default:
+        if (invoker != null) {
+          return invoker.invokeRatisServer(
+              method.getName(), method.getParameterTypes(), args);
+        }

Review Comment:
   This change does not help since it is after the proxy.  We should do it 
before the proxy.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to