AdyChechani opened a new pull request, #10021: URL: https://github.com/apache/ozone/pull/10021
## What changes were proposed in this pull request? * Made `java_major_version` a local variable so it doesn’t leak into the broader shell environment. * GC options now go into a local variable. Passing `XX` as the `checkstring` takes care of duplicate options, so there’s no need for the old `[[ ! "$OZONE_OPTS" =~ "-XX" ]]` check. * Removed `ozone_error` messages, instead used `ozone_debug`. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-14890 ## How was this patch tested? Tested the function `ozone_add_default_gc_opts ` in isolation manually by creating a shell script locally, verifying that: - Default GC options are correctly appended to `OZONE_OPTS` - No duplicate `-XX` options are added when one is already present -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
