rakeshadr commented on code in PR #10000: URL: https://github.com/apache/ozone/pull/10000#discussion_r3038092049
########## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java: ########## Review Comment: Since this PR is adding more stricter/defensive "two-window tumbling bucket" logic, there is a high chance to hit the `return null` code path flow. Please double check all the callers of API [ContainerManagerImpl#allocateContainer()](https://github.com/apache/ozone/blob/master/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManagerImpl.java#L245) then safeguard with null check, otw it would result in NPE. For example, [SCMClientProtocolServer.java#L258](https://github.com/apache/ozone/blob/master/hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMClientProtocolServer.java#L258), this would hit NPE. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
