yandrey321 commented on code in PR #9947:
URL: https://github.com/apache/ozone/pull/9947#discussion_r3039813027
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/DatanodeConfiguration.java:
##########
@@ -688,6 +702,19 @@ public void validate() {
diskCheckTimeout = DISK_CHECK_TIMEOUT_DEFAULT;
}
+ if (diskCheckRetryGap.isNegative()) {
+ LOG.warn("{} must be greater than zero and was set to {}. Defaulting to
{}",
+ DISK_CHECK_RETRY_GAP_KEY, diskCheckRetryGap,
DISK_CHECK_RETRY_GAP_DEFAULT);
+ diskCheckRetryGap = DISK_CHECK_RETRY_GAP_DEFAULT;
+ }
+
+ if (diskCheckRetryGap.compareTo(diskCheckTimeout) > 0) {
Review Comment:
if there are 3 retries, it should be less than 'diskCheckTimeout/3 -
constant' to allow some runtime for reties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
