sadanand48 commented on code in PR #9985:
URL: https://github.com/apache/ozone/pull/9985#discussion_r3062635124
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/snapshot/SnapshotDiffResponse.java:
##########
@@ -90,19 +108,34 @@ public String toString() {
} else {
str.append("Unknown reason.");
}
- str.append("'. Please retry after ")
- .append(waitTimeInMs)
- .append(" ms.\n");
+
+ if (isReportOnly) {
+ str.append("'.\n Please resubmit the job without using the
--get-report option.\n");
+ } else {
+ str.append("'. Please retry after ").append(waitTimeInMs).append("
ms.\n");
+ }
break;
- case CANCELLED:
- str.append("Snapshot diff job has been CANCELLED.");
+ case REJECTED:
+ str.append("Snapshot diff job is REJECTED.\n");
+ if (isReportOnly) {
+ str.append(" Please resubmit the job without using the --get-report
option.");
+ } else {
+ str.append(" Please retry after ").append(waitTimeInMs).append("
ms.\n");
+ }
+ break;
+ case NOT_FOUND:
+ str.append("No snapshot diff job found. Job may not have been submitted
or was removed during cleanup.\n" +
+ "Submit a new snapshot diff job without using the --get-report
option.\n");
Review Comment:
```suggestion
"Submit a new snapshot diff job without using the --get-report
option.\n");
if (!isReportOnly) {
LOG.error("Invalid state for submit snapshot diff call");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
