bharatviswa504 commented on a change in pull request #2319:
URL: https://github.com/apache/ozone/pull/2319#discussion_r648157399
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java
##########
@@ -220,7 +220,6 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager,
}
break;
case FAILURE:
- omMetrics.decNumKeys(deleteKeys.size());
Review comment:
// reset deleteKeys as request failed.
deleteKeys = new ArrayList<>();
So, even without this fix also I don't see an issue. Have you observed any
issue?
Or you want to avoid unnecessary call to decNumKeys is this the reason for
PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
