guihecheng commented on a change in pull request #2290:
URL: https://github.com/apache/ozone/pull/2290#discussion_r649094012
##########
File path:
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/DatanodeLayout.java
##########
@@ -96,11 +97,14 @@ public static void main(String[] args) {
OzoneContainer.buildContainerSet(volumeSet, containerSet, conf);
volumeSet.shutdown();
+ List<HddsVolume> failedVolumes = StorageVolumeUtil.getHddsVolumesList(
+ volumeSet.getFailedVolumesList());
+
if (verify) {
- for (HddsVolume vol : volumeSet.getFailedVolumesList()) {
+ for (HddsVolume vol : failedVolumes) {
System.out.println("Failed Volume:" + vol.getHddsRootDir());
}
}
- return volumeSet.getFailedVolumesList();
+ return failedVolumes;
Review comment:
Oh, here I think it is dedicated to HddsVolumes since this `dnlayout`
command tries to verify the on-disk layout of all data paths or the single data
path. So we don't have to check metadata volume here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
