ChenSammi commented on PR #10100: URL: https://github.com/apache/ozone/pull/10100#issuecomment-4385438711
> @priyeshkaratha Below things to be checked, > > 1. DB flush is done in monitor thread, earlier is synchronized via ratis call in takeSnapshot(). This may have some impact of partial flush. > > 2. Need recheck idompotency of all operation in SCM @priyeshkaratha , please check and make sure that flush is thread safe. @sumitagrawl , "idompotency check " of all operation in SCM, we can do this in another thread, not related with this change. Flush is called multiple places in SCM, only takeSnapshot goes through ratis. SCM should have the capability to handle raft log reapply correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
