ChenSammi commented on code in PR #10184:
URL: https://github.com/apache/ozone/pull/10184#discussion_r3198878358
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/XceiverServerGrpc.java:
##########
@@ -136,7 +141,8 @@ public XceiverServerGrpc(DatanodeDetails datanodeDetails,
.executor(readExecutors)
.addService(ServerInterceptors.intercept(
xceiverService.bindServiceWithZeroCopy(),
- new GrpcServerInterceptor()));
+ new GrpcServerInterceptor()))
+ .addTransportFilter(connectionLimitFilter);
Review Comment:
@YutaLin , could you figure out what will be the client side behavior when
connection is closed by GrpcConnectionLimitFilter? When SO_BACKLOG is hit,
client will resend the SYNC message. If connection termination will cause
client to fail completely, then we could only keep SO_BACKLOG, though
GrpcConnectionLimitFilter is welly implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
