jojochuang commented on code in PR #10110:
URL: https://github.com/apache/ozone/pull/10110#discussion_r3205088969


##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3946,14 +3946,14 @@
   <property>
     <name>ozone.sst.filtering.service.timeout</name>
     <value>300000ms</value>
-    <tag>OZONE, PERFORMANCE,OM</tag>
+    <tag>OZONE, PERFORMANCE, OM, DELETION</tag>
     <description>A timeout value of sst filtering service.
     </description>
   </property>
   <property>
     <name>ozone.snapshot.defrag.service.timeout</name>

Review Comment:
   not DELETION related.



##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3899,38 +3899,38 @@
   <property>
     <name>ozone.snapshot.filtering.limit.per.task</name>
     <value>2</value>
-    <tag>OZONE, PERFORMANCE, OM</tag>
+    <tag>OZONE, PERFORMANCE, OM, DELETION</tag>
     <description>A maximum number of snapshots to be filtered by
       sst filtering service per time interval.
     </description>
   </property>
   <property>
     <name>ozone.snapshot.deleting.limit.per.task</name>
     <value>10</value>
-    <tag>OZONE, PERFORMANCE, OM</tag>
+    <tag>OZONE, PERFORMANCE, OM, DELETION</tag>
     <description>The maximum number of snapshots that would be reclaimed by
       Snapshot Deleting Service per run.
     </description>
   </property>
   <property>
     <name>ozone.snapshot.defrag.limit.per.task</name>
     <value>1</value>
-    <tag>OZONE, PERFORMANCE, OM</tag>
+    <tag>OZONE, PERFORMANCE, OM, DELETION</tag>
     <description>The maximum number of snapshots that would be defragmented in
       each task run of snapshot defragmentation service.
     </description>
   </property>
   <property>
     <name>ozone.snapshot.filtering.service.interval</name>
     <value>1m</value>
-    <tag>OZONE, PERFORMANCE, OM</tag>
+    <tag>OZONE, PERFORMANCE, OM, DELETION</tag>
     <description>Time interval of the SST File filtering service from Snapshot.
     </description>
   </property>
   <property>
     <name>ozone.snapshot.defrag.service.interval</name>

Review Comment:
   I don't think ozone.snapshot.defrag.service.interval belongs to deletion.



##########
hadoop-hdds/common/src/main/resources/ozone-default.xml:
##########
@@ -3899,38 +3899,38 @@
   <property>
     <name>ozone.snapshot.filtering.limit.per.task</name>
     <value>2</value>
-    <tag>OZONE, PERFORMANCE, OM</tag>
+    <tag>OZONE, PERFORMANCE, OM, DELETION</tag>
     <description>A maximum number of snapshots to be filtered by
       sst filtering service per time interval.
     </description>
   </property>
   <property>
     <name>ozone.snapshot.deleting.limit.per.task</name>
     <value>10</value>
-    <tag>OZONE, PERFORMANCE, OM</tag>
+    <tag>OZONE, PERFORMANCE, OM, DELETION</tag>
     <description>The maximum number of snapshots that would be reclaimed by
       Snapshot Deleting Service per run.
     </description>
   </property>
   <property>
     <name>ozone.snapshot.defrag.limit.per.task</name>

Review Comment:
   not DELETION related.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to