navinko commented on code in PR #10211:
URL: https://github.com/apache/ozone/pull/10211#discussion_r3221877590
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SequenceIdGenerator.java:
##########
@@ -192,21 +199,21 @@ interface StateManager extends SCMHandler {
* Compare And Swap lastId saved in db from expectedLastId to newLastId.
* If based on Ratis, it will submit a raft client request.
*
- * @param sequenceIdName : name of the sequence id.
+ * @param idType : the type of sequence ID.
* @param expectedLastId : the expected lastId saved in db
* @param newLastId : the new lastId to save in db
* @return : result of the C.A.S.
*/
@Replicate
- Boolean allocateBatch(String sequenceIdName,
+ Boolean allocateBatch(SequenceIdType idType,
Review Comment:
Thanks @szetszwo will update the PR as suggested .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
