slfan1989 commented on code in PR #10187:
URL: https://github.com/apache/ozone/pull/10187#discussion_r3230955652
##########
hadoop-ozone/iceberg/src/test/java/org/apache/hadoop/ozone/iceberg/TestRewriteTablePathOzoneAction.java:
##########
@@ -188,6 +190,75 @@ void tablePathRewriteForStartAndEndVersionProvided()
throws Exception {
assertAllInternalPathsRewritten(csvPairs, targetPrefix);
}
+ @Test
+ void executeRejectsMissingLocationPrefix() {
+ NullPointerException exception = assertThrows(NullPointerException.class,
+ () -> new RewriteTablePathOzoneAction(table)
+ .stagingLocation(stagingDir.toString() + "/")
+ .execute());
+
+ assertEquals("Source prefix is null", exception.getMessage());
+ }
+
+ @Test
+ void executeRejectsMissingTargetPrefix() {
+ NullPointerException exception = assertThrows(NullPointerException.class,
+ () -> new RewriteTablePathOzoneAction(table)
+ .rewriteLocationPrefix(sourcePrefix, null));
+
+ assertEquals("Target prefix is null", exception.getMessage());
+ }
+
+ @Test
+ void rewriteLocationPrefixRejectsSameSourceAndTarget() {
+ IllegalArgumentException exception =
assertThrows(IllegalArgumentException.class,
+ () -> new RewriteTablePathOzoneAction(table)
+ .rewriteLocationPrefix(sourcePrefix, sourcePrefix)
+ .execute());
+
+ assertEquals("Source prefix cannot be the same as target prefix (" +
+ sourcePrefix + ")", exception.getMessage());
+ }
+
+ @Test
+ void startVersionRejectsUnknownVersion() {
+ IllegalArgumentException exception =
assertThrows(IllegalArgumentException.class,
+ () -> new RewriteTablePathOzoneAction(table)
+ .rewriteLocationPrefix(sourcePrefix, targetPrefix)
+ .startVersion("missing.metadata.json")
+ .execute());
+
+ assertEquals("Cannot find provided version file missing.metadata.json " +
+ "in metadata log.", exception.getMessage());
+ }
+
+ @Test
+ void startVersionRejectsDeletedVersionFile() {
+ List<String> metadataPaths = metadataLogEntryPaths(table);
Review Comment:
@sreejasahithi Added the corresponding end version test case where the
version exists in the metadata log but the physical metadata file is missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
