smengcl commented on a change in pull request #2321:
URL: https://github.com/apache/ozone/pull/2321#discussion_r652174327
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconContainerManager.java
##########
@@ -223,12 +236,16 @@ public void addNewContainer(ContainerWithPipeline
containerWithPipeline)
ContainerInfo containerInfo = containerWithPipeline.getContainerInfo();
try {
if (containerInfo.getState().equals(HddsProtos.LifeCycleState.OPEN)) {
- PipelineID pipelineID = containerWithPipeline.getPipeline().getId();
+ Pipeline pipeline = containerWithPipeline.getPipeline();
+ PipelineID pipelineID = pipeline.getId();
Review comment:
Let's also restore these two lines, doesn't seem necessary any more.
##########
File path:
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconContainerManager.java
##########
@@ -223,12 +236,16 @@ public void addNewContainer(ContainerWithPipeline
containerWithPipeline)
ContainerInfo containerInfo = containerWithPipeline.getContainerInfo();
try {
if (containerInfo.getState().equals(HddsProtos.LifeCycleState.OPEN)) {
- PipelineID pipelineID = containerWithPipeline.getPipeline().getId();
+ Pipeline pipeline = containerWithPipeline.getPipeline();
+ PipelineID pipelineID = pipeline.getId();
Review comment:
Let's also restore these two lines. The change doesn't seem necessary
any more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
