sarvekshayr opened a new pull request, #10276:
URL: https://github.com/apache/ozone/pull/10276

   ## What changes were proposed in this pull request?
   `ContainerStateManager#transitionDeletingOrDeletedToTargetState` is 
annotated with `@Replicate` and takes 
`org.apache.hadoop.hdds.protocol.proto.HddsProtos.LifeCycleState` as a 
parameter. After [HDDS-14748](https://issues.apache.org/jira/browse/HDDS-14748) 
(non-reflection `ScmGeneratedMessageCodec` / explicit codec registration for 
Ratis serialization), callers need a `ScmCodec` registered for every 
protobuf-derived type used in replicated method arguments—including protobuf 
enums handled via `ScmEnumCodec`.
   
   `LifeCycleState` was not registered in `ScmCodecFactory`. That can cause 
`InvalidProtocolBufferException` (“Codec not found …”) when the leader submits 
or followers apply this Ratis transaction.
   
   ## What is the link to the Apache JIRA
   [HDDS-15281](https://issues.apache.org/jira/browse/HDDS-15281)
   
   ## How was this patch tested?
   Added a new test to scan every `@Replicate` method on known SCM handlers and 
asserts each parameter type resolves to a codec. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to