slfan1989 commented on code in PR #10284:
URL: https://github.com/apache/ozone/pull/10284#discussion_r3252642841
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java:
##########
@@ -332,17 +332,33 @@ private synchronized DiskBalancerInfo
readDiskBalancerInfoFile(
private synchronized void writeDiskBalancerInfoTo(
DiskBalancerInfo diskBalancerInfo, File path)
throws IOException {
- if (path.exists()) {
- if (!path.delete() || !path.createNewFile()) {
- throw new IOException("Unable to overwrite the DiskBalancerInfo
file.");
- }
- } else {
- if (!path.getParentFile().exists() &&
- !path.getParentFile().mkdirs()) {
- throw new IOException("Unable to create DiskBalancerInfo
directories.");
- }
+ writeDiskBalancerInfoFile(diskBalancerInfo, path);
+ }
+
+ @VisibleForTesting
+ static void writeDiskBalancerInfoFile(DiskBalancerInfo diskBalancerInfo,
Review Comment:
That makes sense.
Since `YamlUtils` already provides the atomic write behavior, a separate
static helper is not strictly needed.
I will simplify the change by keeping the logic inside
`writeDiskBalancerInfoTo()`, remove the extra static method, and only add
parent directory creation plus clearer exception wrapping around the existing
`DiskBalancerYaml.createDiskBalancerInfoFile()` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
