devmadhuu commented on code in PR #10199:
URL: https://github.com/apache/ozone/pull/10199#discussion_r3252882335
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/keyvalue/TestKeyValueContainer.java:
##########
@@ -492,6 +495,68 @@ public void
testContainerImportExport(ContainerTestVersionInfo versionInfo)
}
}
+ @ContainerTestVersionInfo.ContainerTest
+ public void testFailedImportCleanupMovesContainerBeforeDelete(
+ ContainerTestVersionInfo versionInfo) throws Exception {
+ init(versionInfo);
+
+ HddsVolume containerVolume = volumeChoosingPolicy.chooseVolume(
+ StorageVolumeUtil.getHddsVolumesList(volumeSet.getVolumesList()), 1);
+
+ KeyValueContainer container = new KeyValueContainer(
+ keyValueContainerData, CONF) {
+ @Override
+ void deleteDirectory(File directory) throws IOException {
+ File deletedContainerDir = KeyValueContainerUtil.getTmpDirectoryPath(
+ getContainerData(), getContainerData().getVolume()).toFile();
+ if (directory.equals(deletedContainerDir)) {
+ throw new IOException("Injected tmp cleanup failure");
+ }
+ super.deleteDirectory(directory);
+ }
+ };
+ container.populatePathFields(scmId, containerVolume);
+
+ ContainerPacker<KeyValueContainerData> failingPacker =
+ new ContainerPacker<KeyValueContainerData>() {
+ @Override
+ public byte[] unpackContainerData(
+ Container<KeyValueContainerData> containerToUnpack,
+ InputStream inputStream, Path tmpDir, Path destContainerDir)
+ throws IOException {
+ Files.createDirectories(new File(containerToUnpack
+ .getContainerData().getChunksPath()).toPath());
+ Files.createDirectories(new File(containerToUnpack
+ .getContainerData().getMetadataPath()).toPath());
+ throw new IOException("Injected import failure");
+ }
+
+ @Override
+ public void pack(Container<KeyValueContainerData> containerToPack,
+ OutputStream destination) {
+ }
+
+ @Override
+ public byte[] unpackContainerDescriptor(InputStream inputStream) {
+ return null;
+ }
+ };
+
+ assertThrows(IOException.class, () -> container.importContainerData(
+ new ByteArrayInputStream(new byte[0]), failingPacker));
+
+ assertFalse(new File(container.getContainerData().getContainerPath())
+ .exists());
+ File deletedContainerDir = KeyValueContainerUtil.getTmpDirectoryPath(
+ container.getContainerData(), container.getContainerData().getVolume())
+ .toFile();
+ assertTrue(deletedContainerDir.exists());
+ assertTrue(new File(deletedContainerDir, OzoneConsts.STORAGE_DIR_CHUNKS)
+ .exists());
+ assertTrue(new File(deletedContainerDir, OzoneConsts.CONTAINER_META_PATH)
+ .exists());
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
