ArafatKhan2198 commented on code in PR #9915:
URL: https://github.com/apache/ozone/pull/9915#discussion_r3264702033
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconControllerModule.java:
##########
@@ -131,6 +131,12 @@ protected void configure() {
install(new ReconOmTaskBindingModule());
install(new ReconDaoBindingModule());
bind(ReconTaskStatusUpdaterManager.class).in(Singleton.class);
+ // Only install chatbot bindings when the feature is explicitly enabled.
+ // This prevents startup-time failures (e.g. bad credential provider paths)
+ // from breaking Recon when the chatbot is intentionally disabled.
+ if (ChatbotConfigKeys.isChatbotEnabled(new ConfigurationProvider().get()))
{
Review Comment:
Done. Added getConf() on ReconServer and changed the guard to
ChatbotConfigKeys.isChatbotEnabled(reconServer.getConf()) so we use the config
from the server instance already held by ReconControllerModule instead of going
through ConfigurationProvider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
