adoroszlai commented on code in PR #10310:
URL: https://github.com/apache/ozone/pull/10310#discussion_r3267263810
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/io_/retry/RetryInvocationHandler.java:
##########
Review Comment:
Thanks. I'll leave it for now, but while checking it, I spotted a potential
bug (both here and in Hadoop):
1. `RetryInfo.retryTime` is calculated when it is created:
https://github.com/apache/ozone/blob/c917a6e60d36e0c5b628ab93cc80feaf10c590ff/hadoop-hdds/common/src/main/java/org/apache/hadoop/io_/retry/RetryInvocationHandler.java#L253-L254
2. `waitTime` is calculated before `sleep` as:
https://github.com/apache/ozone/blob/c917a6e60d36e0c5b628ab93cc80feaf10c590ff/hadoop-hdds/common/src/main/java/org/apache/hadoop/io_/retry/RetryInvocationHandler.java#L85-L86
3. but then original `RetryInfo.delay` is used for actual sleep time:
https://github.com/apache/ozone/blob/c917a6e60d36e0c5b628ab93cc80feaf10c590ff/hadoop-hdds/common/src/main/java/org/apache/hadoop/io_/retry/RetryInvocationHandler.java#L131-L136
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
