greenwich commented on code in PR #10303:
URL: https://github.com/apache/ozone/pull/10303#discussion_r3270287155
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java:
##########
@@ -163,11 +171,15 @@ public void create(VolumeSet volumeSet,
VolumeChoosingPolicy
HddsVolume containerVolume;
String hddsVolumeDir;
try {
- containerVolume = volumeChoosingPolicy.chooseVolume(volumes,
maxSize);
+ containerVolume = storageType == null
Review Comment:
Is this branch transitional? Once all VolumeChoosingPolicy impls extend
AbstractStorageTypeChoosingPolicy, chooseVolume(v, s, null) already routes
correctly — so the storageType == null arm looks unreachable. Happy to drop
this if it's cleaned up in a later patch of the series
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
