ChenSammi commented on code in PR #10255:
URL: https://github.com/apache/ozone/pull/10255#discussion_r3271092937
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/AbstractContainerReportHandler.java:
##########
@@ -314,19 +314,23 @@ private boolean updateContainerState(final
DatanodeDetails datanode,
deleteReplica(containerId, datanode, publisher, "DELETED", false,
detailsForLogging);
return false;
}
- if
(container.getReplicationType().equals(HddsProtos.ReplicationType.EC)) {
+ if (replicationType.equals(HddsProtos.ReplicationType.EC)) {
// In case of EC container, delete its replica to avoid orphan replica
deleteReplica(containerId, datanode, publisher, "DELETED", true,
detailsForLogging);
return false;
}
// HDDS-12421: fall-through to case DELETING
case DELETING:
+ if (replicationType.equals(HddsProtos.ReplicationType.EC) &&
!replicaIsEmpty) {
Review Comment:
I'm not sure if (!replicaIsEmpty) is needed here.
@sodonnel , could you take a look of this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
