avijayanhwx commented on pull request #2347: URL: https://github.com/apache/ozone/pull/2347#issuecomment-864623094
> does it mean the the io.netty packages are shaded into the uber jar, but they are not relocated to classpath org.apache.hadoop.ozone.io.netty? If so it could cause problems if downstream application don't use the same netty version. Netty is already shaded by Apache Ratis (which is the source of the dependency here). Moreover, we are only skipping the shading where the match phrase is **io!netty!** (Note the '!'). This is to done skip the shading of [this](https://github.com/netty/netty/blob/master/common/src/main/java/io/netty/util/internal/NativeLibraryLoader.java#L118) piece of code that is meant to not be shaded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
