devmadhuu commented on code in PR #10258:
URL: https://github.com/apache/ozone/pull/10258#discussion_r3274078905


##########
hadoop-ozone/integration-test-recon/src/test/java/org/apache/hadoop/ozone/recon/TestReconAndAdminContainerCLI.java:
##########
@@ -104,6 +105,13 @@ class TestReconAndAdminContainerCLI {
 
   private static final Logger LOG = 
LoggerFactory.getLogger(TestReconAndAdminContainerCLI.class);
 
+  /** Pause between SCM/Recon checks while waiting for matching reports. */
+  private static final int RM_RECON_COMPARE_POLL_INTERVAL_MS = 1000;
+  /** Max wait (Recon can trail SCM briefly). */
+  private static final int RM_RECON_COMPARE_WAIT_MS = 90_000;
+  /** Matching reports must hold this many polls in a row. */
+  private static final int RM_RECON_COMPARE_STABLE_POLLS = 2;

Review Comment:
   Add a one-line comment on `RM_RECON_COMPARE_STABLE_POLLS` explaining why 2 
(e.g., "two full 1-second cycles of RM+Recon agreement to rule out a transient 
crossing").



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to