smengcl commented on PR #10319: URL: https://github.com/apache/ozone/pull/10319#issuecomment-4502121994
### Code review No issues found. Verified this is a faithful backport of upstream commit [`59ad0a1`](https://github.com/apache/ozone/commit/59ad0a1d7fb6fd5543cc9c9cf11d8b9473325478) (HDDS-14104, #9493) to `ozone-2.1`: - All 5 files in PR HEAD [`9906194`](https://github.com/apache/ozone/commit/99061948eb7b56885fe67f0135d317d1779a394f) end at the same blob as upstream master post-merge (`RequestContext.java` → `44e0f928`; the 4 test files have identical blob SHAs to upstream). - The cherry-pick conflict in [RequestContext.java](https://github.com/apache/ozone/blob/99061948eb7b56885fe67f0135d317d1779a394f/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/security/acl/RequestContext.java) was caused by the [HDDS-13753](https://issues.apache.org/jira/browse/HDDS-13753) `ipc` → `ipc_` import rename being present on master but not on `ozone-2.1`. Resolution is correct: HDDS-14104 deletes both the import and its only caller (`getBuilder(ugi, aclType, ownerName)`) entirely, so the package-name divergence is moot. - All callers of the removed APIs (`new RequestContext(...)`, `new RequestContext.Builder()`, `getBuilder(...)`) on `ozone-2.1` are tests, all updated by this PR. No production callers are left broken. - All reviewer feedback from upstream PR #9493 is preserved in the backport. 🤖 Generated with [Claude Code](https://claude.ai/code) <sub>- If this code review was useful, please react with 👍. Otherwise, react with 👎.</sub> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
